linux-ext4 - Re: [PATCH 10/12] xfs/528: require a real SCRATCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251211045724.GD26257@lst.de>
Date: Thu, 11 Dec 2025 05:57:24 +0100
From: Christoph Hellwig <hch@....de>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Zorro Lang <zlang@...nel.org>,
	Anand Jain <anand.jain@...cle.com>,
	Filipe Manana <fdmanana@...e.com>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 10/12] xfs/528: require a real SCRATCH_RTDEV

On Wed, Dec 10, 2025 at 11:52:20AM -0800, Darrick J. Wong wrote:
> >  	log "Format rtextsize=$rextsize"
> > -	_scratch_unmount
> >  	_scratch_mkfs -r extsize=$rextsize >> $seqres.full
> >  	_try_scratch_mount || \
> >  		_notrun "Could not mount rextsize=$rextsize with synthetic rt volume"
> > @@ -150,30 +138,16 @@ test_ops() {
> >  	check_file $SCRATCH_MNT/lpunch
> >  
> >  	log "Check everything, rextsize=$rextsize"
> > +	_scratch_unmount
> >  	_check_scratch_fs
> 
> Why does _scratch_unmount move to this part of the loop?  Unmounting the
> filesystem means that _check_xfs_filesystem won't run xfs_scrub on it.
> 
> (Everything else looks ok.)

Because it now it also is mounted inside the loop and not before the
loop, so unmounting it in the beginning won't work.  But I'll sort out
the order vs _check_scratch_fs.