linux-ext4 - Re: [PATCH 02/13] ext4/006: call e2fsck directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251215194214.GO7725@frogsfrogsfrogs>
Date: Mon, 15 Dec 2025 11:42:14 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Zorro Lang <zlang@...nel.org>, Anand Jain <asj@...nel.org>,
	Filipe Manana <fdmanana@...e.com>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 02/13] ext4/006: call e2fsck directly

On Mon, Dec 15, 2025 at 06:27:56AM +0100, Christoph Hellwig wrote:
> On Fri, Dec 12, 2025 at 12:02:46PM -0800, Darrick J. Wong wrote:
> > > diff --git a/tests/ext4/006 b/tests/ext4/006
> > > index 2ece22a4bd1e..ab78e79d272d 100755
> > > --- a/tests/ext4/006
> > > +++ b/tests/ext4/006
> > > @@ -44,7 +44,7 @@ repair_scratch() {
> > >  	res=$?
> > >  	if [ "${res}" -eq 0 ]; then
> > >  		echo "++ allegedly fixed, reverify" >> "${FSCK_LOG}"
> > > -		_check_scratch_fs -n >> "${FSCK_LOG}" 2>&1
> > > +		e2fsck -n "${SCRATCH_DEV}" >> "${FSCK_LOG}" 2>&1
> > 
> > Minor nit: $E2FSCK_PROG, not e2fsck.
> 
> This test harcoded "e2fsck" right above the diff context, so this is just
> trying to be consistent.

Oh right, I forgot that e2fsck has that odd quirk.  Comment withdrawn.

--D