linux-ext4 - Re: [PATCH 7/6] fs: improve comment in fserror_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <z64qfesodgulcztm7377w475vpriwo47svljmvorwdqmoxo5qm@konpxvnqn4se>
Date: Wed, 7 Jan 2026 10:19:59 +0100
From: Jan Kara <jack@...e.cz>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: jack@...e.cz, brauner@...nel.org, linux-api@...r.kernel.org, 
	hch@....de, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, gabriel@...sman.be, amir73il@...il.com
Subject: Re: [PATCH 7/6] fs: improve comment in fserror_alloc_event

On Tue 06-01-26 15:33:49, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@...nel.org>
> 
> Document the ordering requirements between SB_ACTIVE and
> s_pending_errors in the new fserror code.
> 
> Cc: jack@...e.cz
> Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>

Thanks! I guess this will be folded into the original patch but just in
case:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/fserror.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/fserror.c b/fs/fserror.c
> index ec92f5a6db59ce..06ca86adab9b76 100644
> --- a/fs/fserror.c
> +++ b/fs/fserror.c
> @@ -79,6 +79,11 @@ static inline struct fserror_event *fserror_alloc_event(struct super_block *sb,
>  	 * If pending_errors already reached zero or is no longer active,
>  	 * the superblock is being deactivated so there's no point in
>  	 * continuing.
> +	 *
> +	 * The order of the check of s_pending_errors and SB_ACTIVE are
> +	 * mandated by order of accesses in generic_shutdown_super and
> +	 * fserror_unmount.  Barriers are implicitly provided by the refcount
> +	 * manipulations in this function and fserror_unmount.
>  	 */
>  	if (!refcount_inc_not_zero(&sb->s_pending_errors))
>  		return NULL;
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR