linux-ext4 - Re: [PATCH v3 07/16] ext4: Report case sensitivity in fileattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76zoosya47hgvau4bajvpqupogjpbx5wtljtwltp7pzggkyj7m@lco5on2kmf7g>
Date: Tue, 13 Jan 2026 12:50:18 +0100
From: Jan Kara <jack@...e.cz>
To: Chuck Lever <cel@...nel.org>
Cc: vira@...p.suse.de, Christian Brauner <brauner@...nel.org>, 
	Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, 
	linux-xfs@...r.kernel.org, linux-cifs@...r.kernel.org, linux-nfs@...r.kernel.org, 
	linux-f2fs-devel@...ts.sourceforge.net, hirofumi@...l.parknet.co.jp, linkinjeon@...nel.org, 
	sj1557.seo@...sung.com, yuezhang.mo@...y.com, almaz.alexandrovich@...agon-software.com, 
	slava@...eyko.com, glaubitz@...sik.fu-berlin.de, frank.li@...o.com, tytso@....edu, 
	adilger.kernel@...ger.ca, cem@...nel.org, sfrench@...ba.org, pc@...guebit.org, 
	ronniesahlberg@...il.com, sprasad@...rosoft.com, trondmy@...nel.org, anna@...nel.org, 
	jaegeuk@...nel.org, chao@...nel.org, hansg@...nel.org, senozhatsky@...omium.org, 
	Chuck Lever <chuck.lever@...cle.com>
Subject: Re: [PATCH v3 07/16] ext4: Report case sensitivity in fileattr_get

On Mon 12-01-26 12:46:20, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@...cle.com>
> 
> Report ext4's case sensitivity behavior via file_kattr boolean
> fields. ext4 always preserves case at rest.
> 
> Case sensitivity is a per-directory setting in ext4. If the queried
> inode is a casefolded directory, report case-insensitive; otherwise
> report case-sensitive (standard POSIX behavior).
> 
> Signed-off-by: Chuck Lever <chuck.lever@...cle.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/ioctl.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 7ce0fc40aec2..653035017c7f 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -996,6 +996,14 @@ int ext4_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
>  	if (ext4_has_feature_project(inode->i_sb))
>  		fa->fsx_projid = from_kprojid(&init_user_ns, ei->i_projid);
>  
> +	/*
> +	 * ext4 always preserves case. If this inode is a casefolded
> +	 * directory, report case-insensitive; otherwise report
> +	 * case-sensitive (standard POSIX behavior).
> +	 */
> +	fa->case_insensitive = IS_CASEFOLDED(inode);
> +	fa->case_preserving = true;
> +
>  	return 0;
>  }
>  
> -- 
> 2.52.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR