linux-ext4 - Re: [PATCH v3 06/16] hfsplus: Report case sensitivity in fileattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd9402e9fd09580d8f1adcff2f4785fd482cf8ec.camel@ibm.com>
Date: Tue, 13 Jan 2026 17:36:01 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "cel@...nel.org" <cel@...nel.org>, "jack@...e.cz" <jack@...e.cz>,
        "brauner@...nel.org" <brauner@...nel.org>,
        "vira@....codeaurora.org"
	<vira@....codeaurora.org>
CC: "glaubitz@...sik.fu-berlin.de" <glaubitz@...sik.fu-berlin.de>,
        "chuck.lever@...cle.com" <chuck.lever@...cle.com>,
        "chao@...nel.org"
	<chao@...nel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "linkinjeon@...nel.org" <linkinjeon@...nel.org>,
        "linux-cifs@...r.kernel.org"
	<linux-cifs@...r.kernel.org>,
        "pc@...guebit.org" <pc@...guebit.org>,
        "yuezhang.mo@...y.com" <yuezhang.mo@...y.com>,
        "almaz.alexandrovich@...agon-software.com"
	<almaz.alexandrovich@...agon-software.com>,
        "hirofumi@...l.parknet.co.jp"
	<hirofumi@...l.parknet.co.jp>,
        "slava@...eyko.com" <slava@...eyko.com>,
        "anna@...nel.org" <anna@...nel.org>,
        "linux-f2fs-devel@...ts.sourceforge.net"
	<linux-f2fs-devel@...ts.sourceforge.net>,
        "linux-nfs@...r.kernel.org"
	<linux-nfs@...r.kernel.org>,
        "tytso@....edu" <tytso@....edu>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "trondmy@...nel.org"
	<trondmy@...nel.org>,
        "cem@...nel.org" <cem@...nel.org>,
        "ronniesahlberg@...il.com" <ronniesahlberg@...il.com>,
        "jaegeuk@...nel.org"
	<jaegeuk@...nel.org>,
        "linux-fsdevel@...r.kernel.org"
	<linux-fsdevel@...r.kernel.org>,
        "adilger.kernel@...ger.ca"
	<adilger.kernel@...ger.ca>,
        "sfrench@...ba.org" <sfrench@...ba.org>,
        "frank.li@...o.com" <frank.li@...o.com>,
        "sprasad@...rosoft.com"
	<sprasad@...rosoft.com>,
        "hansg@...nel.org" <hansg@...nel.org>,
        "senozhatsky@...omium.org" <senozhatsky@...omium.org>
Subject: Re:  [PATCH v3 06/16] hfsplus: Report case sensitivity in
 fileattr_get

On Mon, 2026-01-12 at 12:46 -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@...cle.com>
> 
> Add case sensitivity reporting to the existing hfsplus_fileattr_get()
> function. HFS+ always preserves case at rest.
> 
> Case sensitivity depends on how the volume was formatted: HFSX
> volumes may be either case-sensitive or case-insensitive, indicated
> by the HFSPLUS_SB_CASEFOLD superblock flag.
> 
> Signed-off-by: Chuck Lever <chuck.lever@...cle.com>
> ---
>  fs/hfsplus/inode.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 7ae6745ca7ae..0ce9561c0f18 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -694,6 +694,7 @@ int hfsplus_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
>  {
>  	struct inode *inode = d_inode(dentry);
>  	struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
> +	struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb);
>  	unsigned int flags = 0;
>  
>  	if (inode->i_flags & S_IMMUTABLE)
> @@ -705,6 +706,14 @@ int hfsplus_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
>  
>  	fileattr_fill_flags(fa, flags);
>  
> +	/*
> +	 * HFS+ always preserves case. Case sensitivity depends on how
> +	 * the filesystem was formatted: HFSX volumes may be either
> +	 * case-sensitive or case-insensitive.
> +	 */
> +	fa->case_insensitive = test_bit(HFSPLUS_SB_CASEFOLD, &sbi->flags);
> +	fa->case_preserving = true;
> +
>  	return 0;
>  }
>  

Looks good.

Reviewed-by: Viacheslav Dubeyko <slava@...eyko.com>

Thanks,
Slava.