linux-ext4 - Re: [PATCH v2 4/8] ext4: propagate flags to convert_initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4df67ba2-cc04-447a-8cbd-cd655b6539c9@gmail.com>
Date: Sat, 17 Jan 2026 16:59:42 +0800
From: Zhang Yi <yizhang089@...il.com>
To: Ojaswin Mujoo <ojaswin@...ux.ibm.com>, linux-ext4@...r.kernel.org,
 Theodore Ts'o <tytso@....edu>
Cc: Ritesh Harjani <ritesh.list@...il.com>, Zhang Yi <yi.zhang@...wei.com>,
 Jan Kara <jack@...e.cz>, libaokun1@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/8] ext4: propagate flags to
 convert_initialized_extent()

On 1/14/2026 10:57 PM, Ojaswin Mujoo wrote:
> Currently, ext4_zero_range passes EXT4_EX_NOCACHE flag to avoid caching
> extents however this is not respected by convert_initialized_extent().
> Hence, modify it to accept flags from the caller and to pass the flags
> on to other extent manipulation functions it calls. This makes
> sure the NOCACHE flag is respected throughout the code path.
> 
> Also, we no longer explicitly pass CONVERT_UNWRITTEN as the caller takes
> care of this. Account this behavior in Kunit tests as well.
> 
> Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>


It looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>


> ---
>   fs/ext4/extents.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index a581e9278d48..3d45abfb13cd 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3844,6 +3844,7 @@ static struct ext4_ext_path *
>   convert_initialized_extent(handle_t *handle, struct inode *inode,
>   			   struct ext4_map_blocks *map,
>   			   struct ext4_ext_path *path,
> +			   int flags,
>   			   unsigned int *allocated)
>   {
>   	struct ext4_extent *ex;
> @@ -3869,11 +3870,11 @@ convert_initialized_extent(handle_t *handle, struct inode *inode,
>   
>   	if (ee_block != map->m_lblk || ee_len > map->m_len) {
>   		path = ext4_split_convert_extents(handle, inode, map, path,
> -				EXT4_GET_BLOCKS_CONVERT_UNWRITTEN, NULL);
> +						  flags, NULL);
>   		if (IS_ERR(path))
>   			return path;
>   
> -		path = ext4_find_extent(inode, map->m_lblk, path, 0);
> +		path = ext4_find_extent(inode, map->m_lblk, path, flags);
>   		if (IS_ERR(path))
>   			return path;
>   		depth = ext_depth(inode);
> @@ -4263,7 +4264,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
>   			if ((!ext4_ext_is_unwritten(ex)) &&
>   			    (flags & EXT4_GET_BLOCKS_CONVERT_UNWRITTEN)) {
>   				path = convert_initialized_extent(handle,
> -					inode, map, path, &allocated);
> +					inode, map, path, flags, &allocated);
>   				if (IS_ERR(path))
>   					err = PTR_ERR(path);
>   				goto out;