linux-ext4 - Re: [PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ebab91a-8510-40be-a77e-da17dca83e45@gmail.com>
Date: Sat, 24 Jan 2026 16:07:10 +0800
From: Zhang Yi <yizhang089@...il.com>
To: Guoqing Jiang <guoqing.jiang@...ux.dev>, tytso@....edu,
 adilger.kernel@...ger.ca
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove tl argument from
 ext4_fc_replay_{add,del}_range

On 1/21/2026 2:38 PM, Guoqing Jiang wrote:
> Since commit a7ba36bc94f2 ("ext4: fix fast commit alignment issues"),
> both ext4_fc_replay_add_range and ext4_fc_replay_del_range get
> ex based on 'val' instead of 'tl'.
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@...ux.dev>

Thank you for the cleanup, it looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>   fs/ext4/fast_commit.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index fa66b08de999..8474ae52f8dd 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1751,8 +1751,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,
>   }
>   
>   /* Replay add range tag */
> -static int ext4_fc_replay_add_range(struct super_block *sb,
> -				    struct ext4_fc_tl_mem *tl, u8 *val)
> +static int ext4_fc_replay_add_range(struct super_block *sb, u8 *val)
>   {
>   	struct ext4_fc_add_range fc_add_ex;
>   	struct ext4_extent newex, *ex;
> @@ -1872,8 +1871,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
>   
>   /* Replay DEL_RANGE tag */
>   static int
> -ext4_fc_replay_del_range(struct super_block *sb,
> -			 struct ext4_fc_tl_mem *tl, u8 *val)
> +ext4_fc_replay_del_range(struct super_block *sb, u8 *val)
>   {
>   	struct inode *inode;
>   	struct ext4_fc_del_range lrange;
> @@ -2243,13 +2241,13 @@ static int ext4_fc_replay(journal_t *journal, struct buffer_head *bh,
>   			ret = ext4_fc_replay_unlink(sb, &tl, val);
>   			break;
>   		case EXT4_FC_TAG_ADD_RANGE:
> -			ret = ext4_fc_replay_add_range(sb, &tl, val);
> +			ret = ext4_fc_replay_add_range(sb, val);
>   			break;
>   		case EXT4_FC_TAG_CREAT:
>   			ret = ext4_fc_replay_create(sb, &tl, val);
>   			break;
>   		case EXT4_FC_TAG_DEL_RANGE:
> -			ret = ext4_fc_replay_del_range(sb, &tl, val);
> +			ret = ext4_fc_replay_del_range(sb, val);
>   			break;
>   		case EXT4_FC_TAG_INODE:
>   			ret = ext4_fc_replay_inode(sb, &tl, val);