linux-ext4 - Re: [PATCH v3] ext4: fix dirtyclusters double decrement on fs shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176962347640.1138505.6941853832675498828.b4-ty@mit.edu>
Date: Wed, 28 Jan 2026 13:04:58 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: linux-ext4@...r.kernel.org, Brian Foster <bfoster@...hat.com>
Cc: "Theodore Ts'o" <tytso@....edu>, Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH v3] ext4: fix dirtyclusters double decrement on fs shutdown


On Tue, 13 Jan 2026 12:19:05 -0500, Brian Foster wrote:
> fstests test generic/388 occasionally reproduces a warning in
> ext4_put_super() associated with the dirty clusters count:
> 
>   WARNING: CPU: 7 PID: 76064 at fs/ext4/super.c:1324 ext4_put_super+0x48c/0x590 [ext4]
> 
> Tracing the failure shows that the warning fires due to an
> s_dirtyclusters_counter value of -1. IOW, this appears to be a
> spurious decrement as opposed to some sort of leak. Further tracing
> of the dirty cluster count deltas and an LLM scan of the resulting
> output identified the cause as a double decrement in the error path
> between ext4_mb_mark_diskspace_used() and the caller
> ext4_mb_new_blocks().
> 
> [...]

Applied, thanks!

[1/1] ext4: fix dirtyclusters double decrement on fs shutdown
      commit: 94a8cea54cd935c54fa2fba70354757c0fc245e3

Best regards,
-- 
Theodore Ts'o <tytso@....edu>