linux-ext4 - Re: fsverity speedup and memory usage optimization v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYNdmk1EE5etfUYE@casper.infradead.org>
Date: Wed, 4 Feb 2026 14:54:18 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Al Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	David Sterba <dsterba@...e.com>, Theodore Ts'o <tytso@....edu>,
	Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>,
	Andrey Albershteyn <aalbersh@...hat.com>,
	linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
	fsverity@...ts.linux.dev
Subject: Re: fsverity speedup and memory usage optimization v5

On Mon, Feb 02, 2026 at 01:14:23PM -0800, Eric Biggers wrote:
> - Used the code formatting from 'git clang-format' in the cases where it
>   looks better than the ad-hoc formatting

clang-format makes some bad choices.

>  static int ext4_mpage_readpages(struct inode *inode, struct fsverity_info *vi,
> -		struct readahead_control *rac, struct folio *folio)
> +				struct readahead_control *rac,
> +				struct folio *folio)

Aligning to the opening bracket is one of them.  If anything changes
in a subsequent patch (eg function name, whether or not it's static,
adding a function attribute like __must_check, converting the return
type from int to bool), you have to eitheer break the formatting or
needlessly change the lines which have the subsequent arguments.

Also, you've consumed an extra line in this case.  Just leave the
two tab indent, it's actually easier to read.