linux-ext4 - Re: [PATCH 1/3] xfs/018: remove inline xattr recovery tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260206062716.GO7686@frogsfrogsfrogs>
Date: Thu, 5 Feb 2026 22:27:16 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: zlang@...hat.com, linux-ext4@...r.kernel.org, fstests@...r.kernel.org
Subject: Re: [PATCH 1/3] xfs/018: remove inline xattr recovery tests

On Thu, Feb 05, 2026 at 10:26:12PM -0800, Christoph Hellwig wrote:
> On Thu, Feb 05, 2026 at 10:22:22PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 05, 2026 at 09:59:42PM -0800, Christoph Hellwig wrote:
> > > On Thu, Feb 05, 2026 at 08:56:24AM -0800, Darrick J. Wong wrote:
> > > > "In Linux 7.0 we've changed the extended attribute update code to try to
> > > > take a shortcut for performance reasons.  Before walking through the
> > > > attr intent state machine (slow), the update will check to see if the
> > > > attr structure is in short format and will stay in that format after the
> > > > change.  If so, then the incore inode can be updated and logged, and the
> > > > update is complete (fast) in a single transaction.
> > > > 
> > > > "(Obviously, for complex attr structures or large changes we still walk
> > > > through the intent machinery.)
> > > > 
> > > > "However, xfs/018 tests the behavior of the "larp" error injector, which
> > > > only triggers from inside the attr intent state machine.  Therefore, the
> > > > short format tests don't actually trip the injector.  It makes no sense
> > > > to add a new larp injection callsite for the shortcut because either the
> > > > single transaction gets written to disk or it doesn't."
> > > 
> > > Make sense, but from looking at the test I'm still a bit confused
> > > why it fails (vs just not testing something too useful)
> > 
> > The golden output no longer matches because the attr update doesn't
> > return EIO and shut down the filesystem due to the larp injection.
> 
> Ah, that's the missing bit.  Can you add that blurb to the commit
> message?

Will do!

> With that and the above:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Thanks!

--D