linux-ext4 - Re: [PATCH v2] ext4: fix journal credit check when setting fscrypt context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260213000720.GA2191@quark>
Date: Thu, 12 Feb 2026 16:07:20 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Simon Weber <simon.weber.39@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, tytso@....edu,
	adilger.kernel@...ger.ca, tahsin@...gle.com,
	Anthony Durrer <anthonydev@...tmail.com>
Subject: Re: [PATCH v2] ext4: fix journal credit check when setting fscrypt
 context

On Sat, Feb 07, 2026 at 10:53:03AM +0100, Simon Weber wrote:
>  	if (handle) {
> +		/*
> +		 * Since the inode is new it is ok to pass the XATTR_CREATE flag. This
> +		 * is necessary to match the reamining journal credits check in the
> +		 * set_handle function with the credits allocated for the new inode.
> +		 */

Typo: reamining => remaining

Otherwise this looks good.

Reviewed-by: Eric Biggers <ebiggers@...nel.org>

- Eric