lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201003000748.GB13557@embeddedor> Date: Fri, 2 Oct 2020 19:07:48 -0500 From: "Gustavo A. R. Silva" <gustavoars@...nel.org> To: Jens Axboe <axboe@...nel.dk> Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Kees Cook <keescook@...omium.org> Subject: Re: [PATCH][next] block: scsi_ioctl: Avoid the use of one-element arrays On Fri, Oct 02, 2020 at 05:58:33PM -0600, Jens Axboe wrote: > >>> - void __user *reserved[1]; /* unused, actually */ > >>> + union { > >>> + void __user *reserved[1]; /* unused, actually */ > >>> + void __user *unused; > >>> + }; > >> > >> What's the point of this union, why not just turn it into > >> > >> void * __user *unused; > >> > >> ? > > > > I just don't want to take any chances of breaking any user-space > > application that, for some reason, may be considering that field. > > I guess that's a valid concern, who knows what applications are doing > to an ignored field. > > I'll apply it, thanks. Awesome. :) Thanks. -- Gustavo
Powered by blists - more mailing lists