lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADnq5_PX2LokA0VgC-NLZfCa=k8vc9PWYX5WWVH5RCsEzZc+BQ@mail.gmail.com> Date: Thu, 8 Oct 2020 11:46:20 -0400 From: Alex Deucher <alexdeucher@...il.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org>, David Airlie <airlied@...ux.ie>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, linux-hardening@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>, Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com> Subject: Re: [PATCH 14/14] drm/amd/pm: Replace one-element array with flexible-array in struct ATOM_Vega10_GFXCLK_Dependency_Table On Wed, Oct 7, 2020 at 12:05 PM Gustavo A. R. Silva <gustavoars@...nel.org> wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of one-element or zero-length arrays should no longer be used[2]. > > Use a flexible-array member in struct ATOM_Vega10_GFXCLK_Dependency_Table > instead of a one-element array. > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays > > Build-tested-by: kernel test robot <lkp@...el.com> > Link: https://lore.kernel.org/lkml/5f7d61dd.O8jxxI5C6P9FOb%2Fd%25lkp@intel.com/ > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> This header is shared with firmware, so I'm leaving it as is for consistency. Alex > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h > index c934e9612c1b..a6968009acc4 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h > @@ -163,7 +163,7 @@ typedef struct _ATOM_Vega10_MCLK_Dependency_Record { > typedef struct _ATOM_Vega10_GFXCLK_Dependency_Table { > UCHAR ucRevId; > UCHAR ucNumEntries; /* Number of entries. */ > - ATOM_Vega10_GFXCLK_Dependency_Record entries[1]; /* Dynamically allocate entries. */ > + ATOM_Vega10_GFXCLK_Dependency_Record entries[]; /* Dynamically allocate entries. */ > } ATOM_Vega10_GFXCLK_Dependency_Table; > > typedef struct _ATOM_Vega10_MCLK_Dependency_Table { > -- > 2.27.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists