[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAG48ez2gpW-O9wQQ5u55jsr3PhQbPYPjyur=AfgP--5H==96uQ@mail.gmail.com>
Date: Sat, 17 Oct 2020 02:41:33 +0200
From: Jann Horn <jannh@...gle.com>
To: laniel_francis@...vacyrequired.com
Cc: linux-hardening@...r.kernel.org
Subject: Re: [PATCH v1 2/3] Modify return value of nla_strlcpy to match that
of strscpy.
On Fri, Oct 16, 2020 at 3:02 PM <laniel_francis@...vacyrequired.com> wrote:
> This patch solves part 2 of issue: https://github.com/KSPP/linux/issues/110
>
> Signed-off-by: Francis Laniel <laniel_francis@...vacyrequired.com>
> ---
> include/net/netlink.h | 2 +-
> include/net/pkt_cls.h | 3 ++-
> lib/nlattr.c | 31 ++++++++++++++++++++-----------
> net/sched/act_api.c | 2 +-
> net/sched/sch_api.c | 2 +-
> 5 files changed, 25 insertions(+), 15 deletions(-)
[...]
> diff --git a/lib/nlattr.c b/lib/nlattr.c
> index ab96a5f4b9b8..83dd233bbe3e 100644
> --- a/lib/nlattr.c
> +++ b/lib/nlattr.c
> @@ -713,29 +713,38 @@ EXPORT_SYMBOL(nla_find);
> * @dst: where to copy the string to
> * @nla: attribute to copy the string from
> * @dstsize: size of destination buffer
> + * @returns: -E2BIG if @dstsize is 0 or source buffer length greater than
> + * @dstsize, otherwise it returns the number of copied characters (not
> + * including the trailing %NUL).
> *
> * Copies at most dstsize - 1 bytes into the destination buffer.
> - * The result is always a valid NUL-terminated string. Unlike
> - * strlcpy the destination buffer is always padded out.
> - *
> - * Returns the length of the source buffer.
> + * The result is always a valid NUL-terminated string.
> */
What about tcf_proto_check_kind()?
Powered by blists - more mailing lists