lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202010211648.4CBF3805A9@keescook> Date: Wed, 21 Oct 2020 16:48:37 -0700 From: Kees Cook <keescook@...omium.org> To: laniel_francis@...vacyrequired.com Cc: linux-hardening@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org Subject: Re: [RFC][PATCH v3 2/3] Modify return value of nla_strlcpy to match that of strscpy. On Tue, Oct 20, 2020 at 06:47:06PM +0200, laniel_francis@...vacyrequired.com wrote: > From: Francis Laniel <laniel_francis@...vacyrequired.com> > > nla_strlcpy now returns -E2BIG if src was truncated when written to dst. > It also returns this error value if dstsize is 0 or higher than INT_MAX. > > For example, if src is "foo\0" and dst is 3 bytes long, the result will be: > 1. "foG" after memcpy (G means garbage). > 2. "fo\0" after memset. > 3. -E2BIG is returned because src was not completely written into dst. > > The callers of nla_strlcpy were modified to take into account this modification. > > Signed-off-by: Francis Laniel <laniel_francis@...vacyrequired.com> This looks correct to me. Thanks for the respin! Reviewed-by: Kees Cook <keescook@...omium.org> -- Kees Cook
Powered by blists - more mailing lists