lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201023082920.6addf3cb@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Date: Fri, 23 Oct 2020 08:29:20 -0700 From: Jakub Kicinski <kuba@...nel.org> To: David Laight <David.Laight@...LAB.COM> Cc: Kees Cook <keescook@...omium.org>, Francis Laniel <laniel_francis@...vacyrequired.com>, "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [RFC][PATCH v3 3/3] Rename nla_strlcpy to nla_strscpy. On Fri, 23 Oct 2020 08:07:44 +0000 David Laight wrote: > FWIW I suspect the 'return -ERR on overflow' is going to bite us. > Code that does p += strsxxx(p, ..., lim - p, ...) assuming (or not > caring) about overflow goes badly wrong. I don't really care either way, but in netlink there's usually an attribute per value, nothing combines strings like p += strx..(). Looking at the conversion in patch 2 the callers just want to check for overflow.
Powered by blists - more mailing lists