lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3167137.UV11EXrnFd@machine> Date: Fri, 13 Nov 2020 10:38:33 +0100 From: Francis Laniel <laniel_francis@...vacyrequired.com> To: Kees Cook <keescook@...omium.org> Cc: linux-hardening@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org Subject: Re: [PATCH v4 2/3] Modify return value of nla_strlcpy to match that of strscpy. Le vendredi 30 octobre 2020, 20:25:38 CET Kees Cook a écrit : > On Fri, Oct 30, 2020 at 04:36:46PM +0100, laniel_francis@...vacyrequired.com wrote: > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > > index 2a76a2f5ed88..f9b053b30a7b 100644 > > --- a/net/sched/sch_api.c > > +++ b/net/sched/sch_api.c > > @@ -1170,7 +1170,7 @@ static struct Qdisc *qdisc_create(struct net_device > > *dev,> > > #ifdef CONFIG_MODULES > > > > if (ops == NULL && kind != NULL) { > > > > char name[IFNAMSIZ]; > > > > - if (nla_strlcpy(name, kind, IFNAMSIZ) < IFNAMSIZ) { > > + if (nla_strlcpy(name, kind, IFNAMSIZ) > 0) { > > > > /* We dropped the RTNL semaphore in order to > > > > * perform the module load. So, even if we > > * succeeded in loading the module we have to > > Oops, I think this should be >= 0 ? Good catch! I will modify this, rebase my patch on top of master, test it a bit more than what I did for the v4 and push v5!
Powered by blists - more mailing lists