linux-hardening - Re: [PATCH 007/141] gpio: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f55bca70-5d77-562f-626a-fad51af2857d@embeddedor.com>
Date:   Fri, 20 Nov 2020 12:58:46 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Alban Bedel <albeu@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 007/141] gpio: Fix fall-through warnings for Clang



On 11/20/20 12:56, Andy Shevchenko wrote:
> On Fri, Nov 20, 2020 at 12:25:16PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding a break and a fallthrough statements
>> instead of just letting the code fall through to the next case.
> 
> Shouldn't this go via GPIO tree?

Yeah. Actually, you can ignore this patch, as I already sent two
separate patches for this:

https://lore.kernel.org/lkml/20201119170901.GA22703@embeddedor/
https://lore.kernel.org/lkml/20201119170739.GA22665@embeddedor/

I noticed this immediately after sending this out.

Thanks
--
Gustavo