linux-hardening - Re: [PATCH 090/141] iio: adc: cpcap: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Nov 2020 15:05:04 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH 090/141] iio: adc: cpcap: Fix fall-through warnings for
 Clang

On Fri, 20 Nov 2020 12:36:26 -0600
"Gustavo A. R. Silva" <gustavoars@...nel.org> wrote:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
Hi Gustavo,

I'm assuming there is no 'huge' rush for these an intent is that they will
filter through the various subsystems.  Hence I've queued it up for the
next merge window.

Applied to the togreg branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/iio/adc/cpcap-adc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
> index 64c3cc382311..f19c9aa93f17 100644
> --- a/drivers/iio/adc/cpcap-adc.c
> +++ b/drivers/iio/adc/cpcap-adc.c
> @@ -557,6 +557,7 @@ static void cpcap_adc_setup_bank(struct cpcap_adc *ddata,
>  		break;
>  	case CPCAP_ADC_BATTP_PI16 ... CPCAP_ADC_BATTI_PI17:
>  		value1 |= CPCAP_BIT_RAND1;
> +		break;
>  	default:
>  		break;
>  	}