lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAOtvUMeLZXChtoEUNyy=hwHQDqqncUX5V_=JSH3YaiVNLyTcHw@mail.gmail.com> Date: Sun, 22 Nov 2020 09:54:29 +0200 From: Gilad Ben-Yossef <gilad@...yossef.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, Linux kernel mailing list <linux-kernel@...r.kernel.org>, linux-hardening@...r.kernel.org Subject: Re: [PATCH 075/141] crypto: ccree - Fix fall-through warnings for Clang On Fri, Nov 20, 2020 at 8:34 PM Gustavo A. R. Silva <gustavoars@...nel.org> wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > drivers/crypto/ccree/cc_cipher.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c > index dafa6577a845..cdfee501fbd9 100644 > --- a/drivers/crypto/ccree/cc_cipher.c > +++ b/drivers/crypto/ccree/cc_cipher.c > @@ -97,6 +97,7 @@ static int validate_keys_sizes(struct cc_cipher_ctx *ctx_p, u32 size) > case S_DIN_to_SM4: > if (size == SM4_KEY_SIZE) > return 0; > + break; > default: > break; > } > @@ -139,9 +140,11 @@ static int validate_data_size(struct cc_cipher_ctx *ctx_p, > case DRV_CIPHER_CBC: > if (IS_ALIGNED(size, SM4_BLOCK_SIZE)) > return 0; > + break; > default: > break; > } > + break; > default: > break; > } > -- > 2.27.0 > Acked-by: Gilad Ben-Yossef <gilad@...yossef.com> Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker values of β will give rise to dom!
Powered by blists - more mailing lists