linux-hardening - Re: [PATCH 008/141] IB/hfi1: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201123224404.GC21644@embeddedor>
Date:   Mon, 23 Nov 2020 16:44:04 -0600
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>
Cc:     Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 008/141] IB/hfi1: Fix fall-through warnings for Clang

On Sun, Nov 22, 2020 at 09:30:25AM -0500, Mike Marciniszyn wrote:
> 
> On 11/20/2020 1:25 PM, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> > warnings by explicitly adding multiple break statements instead of just
> > letting the code fall through to the next case.
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> 
> Looks good and tested with TID rdma to cover the interlock case.
> 
> Mike
> 
> Tested-by: Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>

Thanks, Mike.
--
Gustavo