lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201123225935.GW21644@embeddedor> Date: Mon, 23 Nov 2020 16:59:35 -0600 From: "Gustavo A. R. Silva" <gustavoars@...nel.org> To: Michal Simek <michal.simek@...inx.com> Cc: Adrian Hunter <adrian.hunter@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang On Mon, Nov 23, 2020 at 08:00:35AM +0100, Michal Simek wrote: > > > On 20. 11. 20 19:37, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > > warnings by explicitly adding multiple break statements instead of > > letting the code fall through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > > --- > > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > > index 829ccef87426..1f7e42b6ced5 100644 > > --- a/drivers/mmc/host/sdhci-of-arasan.c > > +++ b/drivers/mmc/host/sdhci-of-arasan.c > > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > > > No problem with it. > > Acked-by: Michal Simek <michal.simek@...inx.com> Thanks, Michal. -- Gustavo
Powered by blists - more mailing lists