lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201123093347.719a77cf@xps13> Date: Mon, 23 Nov 2020 09:33:47 +0100 From: Miquel Raynal <miquel.raynal@...tlin.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...com>, linux-mtd@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH 104/141] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang Hi Gustavo, "Gustavo A. R. Silva" <gustavoars@...nel.org> wrote on Fri, 20 Nov 2020 12:37:48 -0600: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a couple of fallthrough pseudo-keywords > instead of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 550bda4d1415..002fa521036f 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat, > switch (b % 4) { > case 2: > bit_position += shifting; > + fallthrough; In patch 100, 101, 102, 103 you 'break' in this case (when the statement falls into the empty following statement which itself breaks). Please make it consistent and use break here, below, and in patch 132. LGTM otherwise. > case 1: > break; > default: > @@ -546,6 +547,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat, > switch (b % 4) { > case 2: > byte_addr += shifting; > + fallthrough; > case 1: > break; > default: Thanks, Miquèl
Powered by blists - more mailing lists