lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJZ5v0hLYWKX__oZdcCY0D20pNqpw8SkiTPOCNOtpqe--QLp4Q@mail.gmail.com> Date: Mon, 23 Nov 2020 12:43:57 +0100 From: "Rafael J. Wysocki" <rafael@...nel.org> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-hardening@...r.kernel.org Subject: Re: [PATCH 064/141] ACPI: Fix fall-through warnings for Clang On Fri, Nov 20, 2020 at 7:34 PM Gustavo A. R. Silva <gustavoars@...nel.org> wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > drivers/acpi/sbshc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c > index 53c2862c4c75..0b3de0e63633 100644 > --- a/drivers/acpi/sbshc.c > +++ b/drivers/acpi/sbshc.c > @@ -231,6 +231,7 @@ static int smbus_alarm(void *context) > case ACPI_SBS_BATTERY: > acpi_os_execute(OSL_NOTIFY_HANDLER, > acpi_smbus_callback, hc); > + break; > default:; Why don't you simply drop the default case below (it's empty anyway)? > } > mutex_unlock(&hc->lock); > -- > 2.27.0 >
Powered by blists - more mailing lists