lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201124144407.GI16084@embeddedor> Date: Tue, 24 Nov 2020 08:44:07 -0600 From: "Gustavo A. R. Silva" <gustavoars@...nel.org> To: Sam Ravnborg <sam@...nborg.org> Cc: Andres Salomon <dilinger@...ued.net>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-geode@...ts.infradead.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang Hi Sam, On Sun, Nov 22, 2020 at 11:05:40PM +0100, Sam Ravnborg wrote: > Hi Gustavo, > On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > > Thanks, applied this and the following patch to drm-misc-next. > Looks forward to have this warning enabled. > > One can only wonder how many hours will be saved by lettting the > compiler tell you a break is missing. This is the kind of bugs you can > stare you blind at. Absolutely. We'll never know how many bugs this will catch in the future decades of kernel development, before the code is even committed/submitted. :) Thanks! -- Gustavo
Powered by blists - more mailing lists