linux-hardening - Re: [PATCH 131/141] tpm: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 06:43:29 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH 131/141] tpm: Fix fall-through warnings for Clang

On Tue, 2020-11-24 at 08:40 -0600, Gustavo A. R. Silva wrote:
> On Tue, Nov 24, 2020 at 12:53:22AM +0200, Jarkko Sakkinen wrote:
> > On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote:
> > > On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote:
> > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > > > by explicitly adding a break statement instead of letting the code fall
> > > > through to the next case.
> > > > 
> > > > Link: https://github.com/KSPP/linux/issues/115
> > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > > > ---
> > > >  drivers/char/tpm/eventlog/tpm1.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> > > > index 2c96977ad080..8aa9057601d6 100644
> > > > --- a/drivers/char/tpm/eventlog/tpm1.c
> > > > +++ b/drivers/char/tpm/eventlog/tpm1.c
> > > > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event,
> > > >                 default:
> > > >                         break;
> > > >                 }
> > > > +               break;
> > > >         default:
> > > >                 break;
> > > >         }
> > > > -- 
> > > > 2.27.0
> > > > 
> > > > 
> > > 
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@....fi>
> > > 
> > > Who is picking these patches?
> 
> I can take it in my tree for 5.11 if people are OK with that. :)
> 
> > > 
> > > /Jarkko
> > 
> > I mean
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> 
> Thanks, Jarkko.
> --
> Gustavo

keyring:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a49bdffa9db63a54a6ac56cdcdef8cc8f404f4b6

TPM:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=1ce46c91fdfe5ebf27a6d328b108c630406d1c8c

Looks good?

/Jarkko