lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMpxmJXD+qiJLoEdFxmceVNyXPDfmvKPwG+SthOS8oHd2GqLuA@mail.gmail.com> Date: Tue, 1 Dec 2020 15:50:12 +0100 From: Bartosz Golaszewski <bgolaszewski@...libre.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Alban Bedel <albeu@...e.fr>, Linus Walleij <linus.walleij@...aro.org>, linux-gpio <linux-gpio@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] gpio: ath79: Fix fall-through warning for Clang On Thu, Nov 19, 2020 at 6:08 PM Gustavo A. R. Silva <gustavoars@...nel.org> wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a > warning by explicitly adding a fallthrough pseudo-keyword to indicate > that the code is intended to fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > drivers/gpio/gpio-ath79.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c > index d5359341cc6b..678ddd375891 100644 > --- a/drivers/gpio/gpio-ath79.c > +++ b/drivers/gpio/gpio-ath79.c > @@ -123,6 +123,7 @@ static int ath79_gpio_irq_set_type(struct irq_data *data, > switch (flow_type) { > case IRQ_TYPE_EDGE_RISING: > polarity |= mask; > + fallthrough; > case IRQ_TYPE_EDGE_FALLING: > case IRQ_TYPE_EDGE_BOTH: > break; > -- > 2.27.0 > Applied, thanks! Bartosz
Powered by blists - more mailing lists