lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 6 Mar 2021 00:31:36 +0900 From: Masahiro Yamada <masahiroy@...nel.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Josh Poimboeuf <jpoimboe@...hat.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Michal Marek <michal.lkml@...kovi.net>, linux-hardening@...r.kernel.org, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Justin Forbes <jforbes@...hat.com>, Ondrej Mosnacek <omosnace@...hat.com>, Frank Eigler <fche@...hat.com>, Kees Cook <keescook@...omium.org> Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules On Fri, Mar 5, 2021 at 4:13 AM Linus Torvalds <torvalds@...ux-foundation.org> wrote: > > On Thu, Mar 4, 2021 at 7:36 AM Masahiro Yamada <masahiroy@...nel.org> wrote: > > > > All the kernel-space objects are rebuilt > > when the compiler is upgraded. > > I very much NAK'ed that one. Why did that go in? When the compiler is upgraded, all objects should be rebuilt by the new compiler, - this keeps Kbuild deterministic, irrespective of whether it is a fresh build, or incremental build. If we do not force the full rebuild, the banner at boot time is no point. [ 0.000000] Linux version 5.8.0-44-generic (buildd@...01-amd64-039) (gcc (Ubuntu 10.2.0-13ubuntu1) 10.2.0, GNU ld (GNU Binutils for Ubuntu) 2.35.1) #50-Ubuntu SMP Tue Feb 9 06:29:41 UTC 2021 (Ubuntu 5.8.0-44.50-generic 5.8.18) It claims it was built by gcc (Ubuntu 10.2.0-13ubuntu1) 10.2.0 but we would never know if it is true for whole objects. Some of them might have been compiled by an older compiler. > Or maybe I NAK'ed another version of it (I think the one I NAK'ed was > from Josh), and didn't realize that there were multiple ones. > > > Linus complaint about GCC plugins not being rebuilt. > > Yes, and that was a separate complaint and not at all tied to the other objects. > > Gcc plugins aren't kernel object files at all. They are very much like > dynamically loadable libraries to gcc itself. > > Linus -- Best Regards Masahiro Yamada
Powered by blists - more mailing lists