linux-hardening - Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210320214831.GA22100@magnolia>
Date:   Sat, 20 Mar 2021 14:48:31 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Dave Chinner <david@...morbit.com>, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3][next] xfs: Replace one-element arrays with
 flexible-array members

On Sat, Mar 20, 2021 at 03:20:55PM -0500, Gustavo A. R. Silva wrote:
> 
> 
> On 3/20/21 15:17, Darrick J. Wong wrote:
> >>>> Below are the results of running xfstests for groups shutdown and log
> >>>> with the following configuration in local.config:
> >>>>
> >>>> export TEST_DEV=/dev/sda3
> >>>> export TEST_DIR=/mnt/test
> >>>> export SCRATCH_DEV=/dev/sda4
> >>>> export SCRATCH_MNT=/mnt/scratch
> >>>>
> >>>> The size for both partitions /dev/sda3 and /dev/sda4 is 25GB.
> >>>
> >>> Looks good to me, will toss it at my fstests cloud and see if anything
> >>> shakes out.  Thanks for cleaning up this goofy thorn-pile!
> >>
> >> Great. It's been fun to work on this. :p
> > 
> > Did you run the /entire/ fstests suite?  With this patch applied to
> > 5.12-rc2, I keep seeing list corruption assertions about an hour into
> 
> Nope; I run xfstests 'shutdown' and 'log' groups on 5.11.0, only.
> 
> How do you run the entire fstests?
> Could you give me some pointers?

./check -g all

(instead of "./check -g shutdown")

> > the test run, and usually on some test that heavily exercises allocating
> > and deleting file extents.  I'll try to look at this patch more closely
> > next week, but I figured I should let you know early, on the off chance
> > something sticks out to you.
> 
> OK. I'll go run my tests on 5.12-rc2.
> 
> Should I run the entire xfstests, too?

Yes, please.

--D

> Thanks
> --
> Gustavo