linux-hardening - Re: [PATCH 038/141] isofs: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db9d74de-ef12-1d55-4007-944c2a4e2904@embeddedor.com>
Date:   Tue, 20 Apr 2021 15:24:53 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 038/141] isofs: Fix fall-through warnings for Clang

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 11/20/20 12:30, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>  fs/isofs/rock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/isofs/rock.c b/fs/isofs/rock.c
> index 94ef92fe806c..4880146babaf 100644
> --- a/fs/isofs/rock.c
> +++ b/fs/isofs/rock.c
> @@ -767,6 +767,7 @@ static int rock_ridge_symlink_readpage(struct file *file, struct page *page)
>  			rs.cont_extent = isonum_733(rr->u.CE.extent);
>  			rs.cont_offset = isonum_733(rr->u.CE.offset);
>  			rs.cont_size = isonum_733(rr->u.CE.size);
> +			break;
>  		default:
>  			break;
>  		}
>