linux-hardening - Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 19:07:07 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through
 warnings for Clang

Hi all,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/21/21 04:39, Simon Horman wrote:
> On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote:
>> On 3/5/21 06:19, Simon Horman wrote:
>>> On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
>>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>>>> by explicitly adding a break statement instead of letting the code fall
>>>> through to the next case.
>>>>
>>>> Link: https://github.com/KSPP/linux/issues/115
>>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>>>
>>> Thanks Gustavo,
>>>
>>> this looks good to me.
>>>
>>> Acked-by: Simon Horman <simon.horman@...ronome.com>
>>
>> Hi all,
>>
>> Friendly ping: who can take this, please?
> 
> Hi Jakub, Hi David,
> 
> I'm happy to repost this patch if it would help with your processes.
> 
>>>> ---
>>>>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> index b3cabc274121..3b8e675087de 100644
>>>> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>>>>  	case NFP_PORT_PF_PORT:
>>>>  	case NFP_PORT_VF_PORT:
>>>>  		nfp_repr_vnic_get_stats64(repr->port, stats);
>>>> +		break;
>>>>  	default:
>>>>  		break;
>>>>  	}
>>>> -- 
>>>> 2.27.0
>>>>