linux-hardening - Re: [PATCH RESEND][next] ipv4: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3739dced-578f-92ae-9444-fc4fa9744b54@embeddedor.com>
Date:   Mon, 17 May 2021 19:31:17 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH RESEND][next] ipv4: Fix fall-through warnings for Clang

Hi,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:05, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?
> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 03:02, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding multiple break statements instead of just
>> letting the code fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>> ---
>>  net/ipv4/ah4.c           | 1 +
>>  net/ipv4/esp4.c          | 1 +
>>  net/ipv4/fib_semantics.c | 1 +
>>  net/ipv4/ip_vti.c        | 1 +
>>  net/ipv4/ipcomp.c        | 1 +
>>  5 files changed, 5 insertions(+)
>>
>> diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c
>> index 36ed85bf2ad5..fab0958c41be 100644
>> --- a/net/ipv4/ah4.c
>> +++ b/net/ipv4/ah4.c
>> @@ -450,6 +450,7 @@ static int ah4_err(struct sk_buff *skb, u32 info)
>>  	case ICMP_DEST_UNREACH:
>>  		if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED)
>>  			return 0;
>> +		break;
>>  	case ICMP_REDIRECT:
>>  		break;
>>  	default:
>> diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
>> index 4b834bbf95e0..6cb3ecad04b8 100644
>> --- a/net/ipv4/esp4.c
>> +++ b/net/ipv4/esp4.c
>> @@ -982,6 +982,7 @@ static int esp4_err(struct sk_buff *skb, u32 info)
>>  	case ICMP_DEST_UNREACH:
>>  		if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED)
>>  			return 0;
>> +		break;
>>  	case ICMP_REDIRECT:
>>  		break;
>>  	default:
>> diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
>> index a632b66bc13a..4c0c33e4710d 100644
>> --- a/net/ipv4/fib_semantics.c
>> +++ b/net/ipv4/fib_semantics.c
>> @@ -1874,6 +1874,7 @@ static int call_fib_nh_notifiers(struct fib_nh *nh,
>>  		    (nh->fib_nh_flags & RTNH_F_DEAD))
>>  			return call_fib4_notifiers(dev_net(nh->fib_nh_dev),
>>  						   event_type, &info.info);
>> +		break;
>>  	default:
>>  		break;
>>  	}
>> diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c
>> index 31c6c6d99d5e..eb560eecee08 100644
>> --- a/net/ipv4/ip_vti.c
>> +++ b/net/ipv4/ip_vti.c
>> @@ -351,6 +351,7 @@ static int vti4_err(struct sk_buff *skb, u32 info)
>>  	case ICMP_DEST_UNREACH:
>>  		if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED)
>>  			return 0;
>> +		break;
>>  	case ICMP_REDIRECT:
>>  		break;
>>  	default:
>> diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
>> index b42683212c65..bbb56f5e06dd 100644
>> --- a/net/ipv4/ipcomp.c
>> +++ b/net/ipv4/ipcomp.c
>> @@ -31,6 +31,7 @@ static int ipcomp4_err(struct sk_buff *skb, u32 info)
>>  	case ICMP_DEST_UNREACH:
>>  		if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED)
>>  			return 0;
>> +		break;
>>  	case ICMP_REDIRECT:
>>  		break;
>>  	default:
>>