linux-hardening - Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 19:33:33 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Jeffrey E Altman <jaltman@...istor.com>,
        "Gustavo A. R. Silva (gustavoars@...nel.org)" <gustavoars@...nel.org>,
        David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang



On 4/21/21 18:03, Jeffrey E Altman wrote:
> On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@...nel.org) wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding multiple fallthrough pseudo-keywords
>> in places where the code is intended to fall through to the next
>> case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>> ---
>> Changes in v2:
>>   - Place blank line after the fallthrough markings, not before.
>>     Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
> 
> This change looks good to me.
> 
> Reviewed-by: Jeffrey Altman <jaltman@...istor.com>

Thanks, Jeffrey.

Could someone take this, please?

Thanks
--
Gustavo