lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 May 2021 15:13:54 -0500 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Steven Rostedt <rostedt@...dmis.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] ring-buffer: Fix fall-through warning for Clang On 5/28/21 15:08, Steven Rostedt wrote: > On Fri, 28 May 2021 14:59:42 -0500 > "Gustavo A. R. Silva" <gustavoars@...nel.org> wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix >> a fall-through warning by replacing a /* fall through */ comment >> with the new pseudo-keyword macro fallthrough; >> >> Notice that Clang doesn't recognize /* fall through */ comments as >> implicit fall-through markings, so in order to globally enable >> -Wimplicit-fallthrough for Clang, these comments need to be >> replaced with fallthrough; in the whole codebase. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> >> --- >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 25 in linux-next. This is one of those last remaining >> warnings. > > And I have it fixed locally already. > > https://lore.kernel.org/lkml/20210511140246.18868-1-jj251510319013@gmail.com/ > > I've just been on vacation and haven't pushed it to next yet. It's still in > the "to be tested" queue. Awesome! :) Thanks, Steven. -- Gustavo
Powered by blists - more mailing lists