lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Jun 2021 12:20:27 -0700 From: Kees Cook <keescook@...omium.org> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Jason Wessel <jason.wessel@...driver.com>, Daniel Thompson <daniel.thompson@...aro.org>, Douglas Anderson <dianders@...omium.org>, kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] kgdb: Fix fall-through warning for Clang On Fri, May 28, 2021 at 03:02:22PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a > fall-through warning by explicitly adding a goto statement instead > of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > JFYI: We had thousands of these sorts of warnings and now we are down > to just 25 in linux-next. This is one of those last remaining > warnings. So close! :) Reviewed-by: Kees Cook <keescook@...omium.org> -Kees > > kernel/debug/debug_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c > index 4708aec492df..431749dd9ab6 100644 > --- a/kernel/debug/debug_core.c > +++ b/kernel/debug/debug_core.c > @@ -1038,6 +1038,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x) > switch (kgdbreboot) { > case 1: > kgdb_breakpoint(); > + goto done; > case -1: > goto done; > } > -- > 2.27.0 > -- Kees Cook
Powered by blists - more mailing lists