linux-hardening - Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

Open Source and information security mailing list archives

Date:   Wed, 2 Jun 2021 02:10:18 +0200
From:   Karol Herbst <kherbst@...hat.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Kees Cook <keescook@...omium.org>,
        nouveau <nouveau@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-hardening@...r.kernel.org
Subject: Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through
 warnings for Clang

all three nouveau patches are

Reviewed-by: Karol Herbst <kherbst@...hat.com>

and I don't think anybody would mind if those get into through other
trees, but maybe drm-mist would be a good place for it if other
patches involve other drm drivers?

On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
> Hi,
>
> Friendly second ping: who can take this?
>
> I can add this to my -next branch for 5.14 if you don't mind.
>
> JFYI: We had thousands of these sorts of warnings and now we are down
> to just 23 in linux-next. This is one of those last remaining warnings.
>
> Thanks
> --
> Gustavo
>
> On 4/20/21 15:13, Gustavo A. R. Silva wrote:
> > Hi all,
> >
> > Friendly ping: who can take this, please?
> >
> > Thanks
> > --
> > Gustavo
> >
> > On 3/5/21 03:56, Gustavo A. R. Silva wrote:
> >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
> >> of warnings by explicitly adding a couple of break statements instead
> >> of letting the code fall through to the next case.
> >>
> >> Link: https://github.com/KSPP/linux/issues/115
> >> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> >> ---
> >>  drivers/gpu/drm/nouveau/nouveau_bo.c        | 1 +
> >>  drivers/gpu/drm/nouveau/nouveau_connector.c | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> >> index 2375711877cf..62903c3b368d 100644
> >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig)
> >>                      break;
> >>              case TTM_PL_TT:
> >>                      error |= !(domain & NOUVEAU_GEM_DOMAIN_GART);
> >> +                    break;
> >>              default:
> >>                      break;
> >>              }
> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
> >> index 61e6d7412505..eb844cdcaec2 100644
> >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector,
> >>                      default:
> >>                              break;
> >>                      }
> >> +                    break;
> >>              case DRM_MODE_SCALE_FULLSCREEN:
> >>              case DRM_MODE_SCALE_CENTER:
> >>              case DRM_MODE_SCALE_ASPECT:
> >>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives