lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202106081002.252C11321F@keescook> Date: Tue, 8 Jun 2021 10:02:35 -0700 From: Kees Cook <keescook@...omium.org> To: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Mimi Zohar <zohar@...ux.ibm.com>, Dmitry Kasatkin <dmitry.kasatkin@...il.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, linux-integrity@...r.kernel.org, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] ima: Fix fall-through warning for Clang On Mon, Jun 07, 2021 at 03:49:34PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a > fall-through warning by explicitly adding a break statement instead > of just letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > --- > JFYI: We had thousands of these sorts of warnings and now we are down > to just 13 in linux-next(20210607). This is one of those last > remaining warnings. :) Looks right to me; thanks! Reviewed-by: Kees Cook <keescook@...omium.org> > > security/integrity/ima/ima_template_lib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/integrity/ima/ima_template_lib.c b/security/integrity/ima/ima_template_lib.c > index 518fd50ea48a..8f96247b4a5c 100644 > --- a/security/integrity/ima/ima_template_lib.c > +++ b/security/integrity/ima/ima_template_lib.c > @@ -119,6 +119,7 @@ static void ima_show_template_data_ascii(struct seq_file *m, > default: > break; > } > + break; > default: > break; > } > -- > 2.27.0 > -- Kees Cook
Powered by blists - more mailing lists