lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <928b163d-b754-4135-f3f3-5f08492f93eb@linux.intel.com> Date: Wed, 9 Jun 2021 15:41:03 +0800 From: Lu Baolu <baolu.lu@...ux.intel.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org>, David Woodhouse <dwmw2@...radead.org>, Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org> Cc: baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2][next] iommu/vt-d: Fix out-bounds-warning in intel_svm_page_response() On 4/15/21 4:14 AM, Gustavo A. R. Silva wrote: > Replace a couple of calls to memcpy() with simple assignments in order > to fix the following out-of-bounds warning: > > drivers/iommu/intel/svm.c:1198:4: warning: 'memcpy' offset [25, 32] from the object at 'desc' is out of the bounds of referenced subobject 'qw2' with type 'long long unsigned int' at offset 16 [-Warray-bounds] > > The problem is that the original code is trying to copy data into a > couple of struct members adjacent to each other in a single call to > memcpy(). This causes a legitimate compiler warning because memcpy() > overruns the length of &desc.qw2 and &resp.qw2, respectively. > > This helps with the ongoing efforts to globally enable -Warray-bounds > and get us closer to being able to tighten the FORTIFY_SOURCE routines > on memcpy(). > > Link:https://github.com/KSPP/linux/issues/109 > Signed-off-by: Gustavo A. R. Silva<gustavoars@...nel.org> Queued for v5.14. Thanks! Best regards, baolu
Powered by blists - more mailing lists