lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jun 2021 12:53:33 -0700 From: Kees Cook <keescook@...omium.org> To: netdev@...r.kernel.org Cc: Kees Cook <keescook@...omium.org>, Sergei Shtylyov <sergei.shtylyov@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Sergey Shtylyov <s.shtylyov@...russia.ru>, Andrew Lunn <andrew@...n.ch>, Wolfram Sang <wsa+renesas@...g-engineering.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Michael Walle <michael@...le.cc>, Yang Yingliang <yangyingliang@...wei.com>, Rikard Falkeborn <rikard.falkeborn@...il.com>, linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-hardening@...r.kernel.org Subject: [PATCH] sh_eth: Avoid memcpy() over-reading of ETH_SS_STATS In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid intentionally reading across neighboring array fields. The memcpy() is copying the entire structure, not just the first array. Adjust the source argument so the compiler can do appropriate bounds checking. Signed-off-by: Kees Cook <keescook@...omium.org> --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 177523be4fb6..840478692a37 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2287,7 +2287,7 @@ static void sh_eth_get_strings(struct net_device *ndev, u32 stringset, u8 *data) { switch (stringset) { case ETH_SS_STATS: - memcpy(data, *sh_eth_gstrings_stats, + memcpy(data, sh_eth_gstrings_stats, sizeof(sh_eth_gstrings_stats)); break; } -- 2.25.1
Powered by blists - more mailing lists