linux-hardening - RE: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of ETH_SS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5662F0A8BAFBC724EA8347E6FA069@SJ0PR11MB5662.namprd11.prod.outlook.com>
Date:   Fri, 25 Jun 2021 22:41:37 +0000
From:   "Brelinski, TonyX" <tonyx.brelinski@...el.com>
To:     Kees Cook <keescook@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of
 ETH_SS_STATS

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kees Cook
> Sent: Wednesday, June 16, 2021 12:53 PM
> To: netdev@...r.kernel.org
> Cc: Kees Cook <keescook@...omium.org>; linux-kernel@...r.kernel.org;
> linux-hardening@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; intel-
> wired-lan@...ts.osuosl.org; David S. Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of
> ETH_SS_STATS
> 
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally reading across neighboring array fields.
> 
> The memcpy() is copying the entire structure, not just the first array.
> Adjust the source argument so the compiler can do appropriate bounds
> checking.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski@...el.com> (A Contingent Worker at Intel)