lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 4 Aug 2021 15:37:42 +0300
From:   Dan Carpenter <>
To:     "Gustavo A. R. Silva" <>
Cc:     Sakari Ailus <>,
        "Gustavo A. R. Silva" <>,, Yong Zhi <>,
        Bingbu Cao <>,
        Tianshu Qiu <>,
        Mauro Carvalho Chehab <>,
        Greg Kroah-Hartman <>,,,
Subject: Re: [PATCH v2 1/2] media: staging/intel-ipu3: css: Fix wrong size

I missed that you change < sizeof() to <= sizeof()...  Sakari is right
that it should be < sizeof().  <= doesn't work at all ever.  If you
wanted a higher limit then the next limit woule be:

	if (css->fw->size < struct_size(css->fwp, binary_header, 1))

dan carpenter

Powered by blists - more mailing lists