lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 18 Aug 2021 13:34:23 +0200
From:   Joerg Roedel <>
To:     Kees Cook <>
Cc:, Will Deacon <>,,
        "Gustavo A. R. Silva" <>,
        Greg Kroah-Hartman <>,
        Andrew Morton <>,,,,,,,,
        Rasmus Villemoes <>,
Subject: Re: [PATCH v2 13/63] iommu/amd: Use struct_group() for memcpy()

On Tue, Aug 17, 2021 at 11:04:43PM -0700, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> Use struct_group() in struct ivhd_entry around members ext and hidh, so
> they can be referenced together. This will allow memcpy() and sizeof()
> to more easily reason about sizes, improve readability, and avoid future
> warnings about writing beyond the end of ext.
> "pahole" shows no size nor member offset changes to struct ivhd_entry.
> "objdump -d" shows no object code changes.
> Cc: Joerg Roedel <>
> Cc: Will Deacon <>
> Cc:
> Signed-off-by: Kees Cook <>

Acked-by: Joerg Roedel <>

Powered by blists - more mailing lists