linux-hardening - Re: [PATCH 1/2] staging/rtl8192u: Avoid CamelCase in names of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 11:54:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Len Baker <len.baker@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH 1/2] staging/rtl8192u: Avoid CamelCase in names of
 variables

On Sun, Aug 22, 2021 at 08:02:14AM -0700, Kees Cook wrote:
> On Sun, Aug 22, 2021 at 04:28:19PM +0200, Len Baker wrote:
> > Avoid CameCase in the names of all local variables inside the function
> > rtl8192_phy_SwChnlStepByStep().
> 
> This mixes decamelization with some (minor) logic changes (moving
> initializations earlier). I'd normally do this kind of thing with a sed
> script and not touch anything else, so that the results can be compared
> against the sed command. And I'd include the sed command in the commit
> log.

Yep.  Absolutely verboten on staging.

> 
> I'm actually not sure what the norm is in the kernel for doing
> decamelization -- should the entire driver get decamelized at once,
> instead of just one function at a time? Greg, do you have an opinion
> here?

It doesn't matter.  One function at a time is fine.  So long as it's not
too long to review.

regards,
dan carpenter