lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 7 Sep 2021 09:55:19 -0700
From:   James Smart <>
To:     Len Baker <>,
        James Smart <>,
        Ram Vegesna <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>
Cc:     Kees Cook <>, Hannes Reinecke <>,,,,
Subject: Re: [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded

On 9/4/2021 11:24 PM, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> So, use the purpose specific kcalloc() function instead of the argument
> count * size in the kzalloc() function.
> [1]
> Signed-off-by: Len Baker <>

Looks good.  Thanks

Reviewed-by: James Smart <>

-- james

Powered by blists - more mailing lists