linux-hardening - Re: [PATCH] i3c/master/mipi-i3c-hci: Prefer struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163155475974.409020.647490102226402116.b4-ty@bootlin.com>
Date:   Mon, 13 Sep 2021 19:39:45 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Len Baker <len.baker@....com>, Nicolas Pitre <npitre@...libre.com>,
        Boris Brezillon <boris.brezillon@...labora.com>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i3c@...ts.infradead.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic

On Sun, 5 Sep 2021 16:40:54 +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> [...]

Applied, thanks!

[1/1] i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic
      commit: 605fa23646dd9a86c4300e1719542a865111d1b6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>