linux-hardening - [GIT PULL] Enable -Wimplicit-fallthrough for Clang for 5.15-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 11:41:00 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>
Subject: [GIT PULL] Enable -Wimplicit-fallthrough for Clang for 5.15-rc2

The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:

  Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git tags/implicit-fallthrough-clang-5.15-rc2

for you to fetch changes up to 236378bb6ca791cbde68eacedd7688084d06177e:

  Makefile: Enable -Wimplicit-fallthrough for Clang (2021-09-13 23:47:12 -0500)

----------------------------------------------------------------
Enable -Wimplicit-fallthrough for Clang for 5.15-rc2

Hi Linus,

Please, pull the following patches that fix the last warnings in
x86_64, ARM and MIPS reported by kernel test robot, and enables
-Wimplicit-fallthrough for Clang 14+, globally.

We had almost 40,000[1] of these issues for Clang in the beginning,
and there might be a couple more out there when building some
architectures with certain configurations. However, with the
recent fixes, I think we are in good shape and it is now possible
to enable -Wimplicit-fallthrough for Clang, with this finally getting rid of
the unintentional fallthrough bug-class in the kernel, entirely. :)

[1] https://github.com/KSPP/linux/issues/115

Thanks!

----------------------------------------------------------------
Gustavo A. R. Silva (4):
      scsi: st: Fix fall-through warning for Clang
      MIPS: Fix fall-through warnings for Clang
      pcmcia: db1xxx_ss: Fix fall-through warning for Clang
      Makefile: Enable -Wimplicit-fallthrough for Clang

 Makefile                             | 8 ++++++++
 arch/mips/alchemy/devboards/db1550.c | 1 +
 arch/mips/kernel/uprobes.c           | 1 +
 drivers/pcmcia/db1xxx_ss.c           | 1 +
 drivers/scsi/st.c                    | 1 +
 5 files changed, 12 insertions(+)