linux-hardening - Re: [PATCH v2] hardening: Avoid harmless Clang option under CONFIG_INIT_STACK_ALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210915075011.GA7321@willie-the-truck>
Date:   Wed, 15 Sep 2021 08:50:17 +0100
From:   Will Deacon <will@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>, llvm@...ts.linux.dev,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] hardening: Avoid harmless Clang option under
 CONFIG_INIT_STACK_ALL_ZERO

On Tue, Sep 14, 2021 at 01:02:03PM -0700, Kees Cook wrote:
> Currently under Clang, CC_HAS_AUTO_VAR_INIT_ZERO requires an extra
> -enable flag compared to CC_HAS_AUTO_VAR_INIT_PATTERN. GCC does not,
> and will happily ignore the Clang-specific flag. However, its presence
> on the command-line is both cumbersome and confusing. Due to GCC's
> tolerant behavior, though, we can continue to use a single Kconfig
> cc-option test for the feature on both compilers, but then drop the
> Clang-specific option in the Makefile.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: llvm@...ts.linux.dev
> Fixes: dcb7c0b9461c ("hardening: Clarify Kconfig text for auto-var-init")
> Suggested-by: Will Deacon <will@...nel.org>
> Link: https://lore.kernel.org/lkml/20210914102837.6172-1-will@kernel.org/
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  Makefile                   | 6 +++---
>  security/Kconfig.hardening | 5 ++++-
>  2 files changed, 7 insertions(+), 4 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

Cheers for sorting this out!

Will