linux-hardening - Re: [PATCH v1 2/6] iio/test-format: build kunit tests without structleak plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Sep 2021 16:58:20 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     shuah@...nel.org, davidgow@...gle.com, arnd@...db.de,
        keescook@...omium.org, rafael@...nel.org, lars@...afoo.de,
        ulf.hansson@...aro.org, andreas.noever@...il.com,
        michael.jamet@...el.com, mika.westerberg@...ux.intel.com,
        YehezkelShB@...il.com, masahiroy@...nel.org,
        michal.lkml@...kovi.net, ndesaulniers@...gle.com,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-hardening@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v1 2/6] iio/test-format: build kunit tests without
 structleak plugin

On Thu, 16 Sep 2021 23:11:00 -0700
Brendan Higgins <brendanhiggins@...gle.com> wrote:

> The structleak plugin causes the stack frame size to grow immensely when
> used with KUnit:
> 
> ../drivers/iio/test/iio-test-format.c: In function ‘iio_test_iio_format_value_fixedpoint’:
> ../drivers/iio/test/iio-test-format.c:98:1: warning: the frame size of 2336 bytes is larger than 2048 bytes [-Wframe-larger-than=]
> 
> Turn it off in this file.
> 
> Co-developed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/iio/test/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/test/Makefile b/drivers/iio/test/Makefile
> index f1099b4953014..467519a2027e5 100644
> --- a/drivers/iio/test/Makefile
> +++ b/drivers/iio/test/Makefile
> @@ -5,3 +5,4 @@
>  
>  # Keep in alphabetical order
>  obj-$(CONFIG_IIO_TEST_FORMAT) += iio-test-format.o
> +CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN)