lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 21 Sep 2021 18:41:24 +0200
From:   Takashi Iwai <>
To:     Len Baker <>
Cc:     Jaroslav Kysela <>, Takashi Iwai <>,
        gushengxian <>,
        Kees Cook <>,
        "Gustavo A. R. Silva" <>,,,
Subject: Re: [PATCH] ALSA: usx2y: Prefer struct_size over open coded arithmetic

On Sun, 19 Sep 2021 15:37:27 +0200,
Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> In this case this is not actually dynamic size: all the operands
> involved in the calculation are constant values. However it is better to
> refactor this anyway, just to keep the open-coded math idiom out of
> code.
> So, use the struct_size() helper to do the arithmetic instead of the
> argument "size + size * count" in the kzalloc() function.
> Also, take the opportunity to refactor the declaration variables to make
> it more easy to read.
> [1]
> Signed-off-by: Len Baker <>

Thanks, applied.


Powered by blists - more mailing lists