lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 23:20:05 -0700 From: Kees Cook <keescook@...omium.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Kees Cook <keescook@...omium.org>, "Tobin C. Harding" <me@...in.cc>, Tycho Andersen <tycho@...ho.pizza>, Helge Deller <deller@....de>, Qi Zheng <zhengqi.arch@...edance.com>, Vito Caputo <vcaputo@...garu.com>, Josh Poimboeuf <jpoimboe@...hat.com>, Jann Horn <jannh@...gle.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Mark Rutland <mark.rutland@....com>, Jens Axboe <axboe@...nel.dk>, Peter Zijlstra <peterz@...radead.org>, Andy Lutomirski <luto@...nel.org>, Lai Jiangshan <laijs@...ux.alibaba.com>, Stefan Metzmacher <metze@...ba.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Christian Brauner <christian.brauner@...ntu.com>, Michal Hocko <mhocko@...e.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Randy Dunlap <rdunlap@...radead.org>, Ohhoon Kwon <ohoono.kwon@...sung.com>, YiFei Zhu <yifeifz2@...inois.edu>, kernel test robot <oliver.sang@...el.com>, linux-kernel@...r.kernel.org, stable@...r.kernel.org, linux-hardening@...r.kernel.org, x86@...nel.org, linux-fsdevel@...r.kernel.org Subject: [PATCH 2/3] leaking_addresses: Always print a trailing newline For files that lack trailing newlines and match a leaking address (e.g. wchan[1]), the leaking_addresses.pl report would run together with the net line, making things look corrupted. Unconditionally remove the newline on input, and write it back out on output. [1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/ Cc: "Tobin C. Harding" <me@...in.cc> Cc: Tycho Andersen <tycho@...ho.pizza> Signed-off-by: Kees Cook <keescook@...omium.org> --- scripts/leaking_addresses.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index b2d8b8aa2d99..8f636a23bc3f 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -455,8 +455,9 @@ sub parse_file open my $fh, "<", $file or return; while ( <$fh> ) { + chomp; if (may_leak_address($_)) { - print $file . ': ' . $_; + printf("$file: $_\n"); } } close $fh; -- 2.30.2
Powered by blists - more mailing lists